Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for relative links and being clear on version dependencies #65

Merged
merged 8 commits into from
Nov 19, 2020

Conversation

cholmes
Copy link
Collaborator

@cholmes cholmes commented Nov 18, 2020

Related Issue(s): #55

Proposed Changes:

  1. Add note about properly checking out submodules
  2. Update stac-spec links to be relative
  3. Make clear the features API dependency
  4. Added a PROCESS.md to have a place to put reminders for release.
  5. Add what updates are needed for a 'release' (update submodule). Ended up making it so you don't need to update
    the stac-spec version - just instructed people to check the CHANGELOG of the submodule to see.

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • OpenAPI files only: I have run npm run generate-all to update the generated OpenAPI files.

@cholmes cholmes marked this pull request as ready for review November 18, 2020 23:35
@@ -0,0 +1,72 @@
## STAC Development & Release Process
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we should have a central place for things that are common across stac-spec and stac-api-spec. It's always a pain to keep things aligned...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to it, but not sure how it would work. I feel like it either is harder for a new user to understand (go look at this repo to find out x, y & z), or it's some complicated technical thing (though maybe submodules come close)?

I sorta figured the release processes would also diverge some.

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good start. Maybe add a CHANGELOG entry for the new definition that this API version only supports spec 0.9 up to 2 (exclusive)?

@cholmes cholmes merged commit a539487 into master Nov 19, 2020
@cholmes cholmes deleted the lock-version branch November 19, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants