-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor link relation tables, make parent not a required field #407
Conversation
Co-authored-by: Matthias Mohr <[email protected]>
Looks great, @philvarner. Thanks for fixing this up. |
I'm actually not sure whether we should drop the requirement. I feel like requiring the parent links (and potentially even more) would help in the long run. I think adding links in API implementations is much "cheaper" than in static catalogs so I'd think we could require more in the API compared to static catalogs. |
Maybe conditional requirements are too sloppy, but how about only requiring |
That's weird as you'd need a condition in implementation, but I also don't think having them twice is an issue. |
Co-authored-by: Tim Schaub <[email protected]>
Co-authored-by: Tim Schaub <[email protected]>
I think if we want to keep Collection parent as required and have Item parent as required (since it was inadvertently added by me without discussion), we can do that, but I'd prefer we have that as a future discussion for 1.0.0-rc.4. I prefer aligning them with STAC definitions for now. I really just want to get 1.0.0-rc.3 out. |
Related Issue(s):
Proposed Changes:
parent
link rel is not required for Collection or Item. In <= 1.0.0-rc.2, it was required for /collections/{collectionId}, and the requirement on /collections/{collectionId}/items/{itemId} was added since 1.0.0-rc.2. This aligns with it not being required in STAC Item and Collection definitions.PR Checklist:
stac-spec
directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)