Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link to STAC API Extensions site instead of listing them #381

Merged
merged 3 commits into from
Jan 31, 2023
Merged

link to STAC API Extensions site instead of listing them #381

merged 3 commits into from
Jan 31, 2023

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

  • n/a

Proposed Changes:

  1. link to STAC API Extensions site instead of listing them

PR Checklist:

  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner requested review from cholmes and m-mohr and removed request for cholmes January 30, 2023 14:05
m-mohr
m-mohr reviewed Jan 30, 2023
View reviewed changes
core/README.md Outdated Show resolved Hide resolved
@philvarner philvarner marked this pull request as draft January 30, 2023 14:56
@philvarner philvarner marked this pull request as ready for review January 30, 2023 22:02
m-mohr
m-mohr reviewed Jan 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Jan 30, 2023
View reviewed changes
core/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Jan 30, 2023
View reviewed changes
item-search/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Jan 30, 2023
View reviewed changes
ogcapi-features/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I've replaced the "here" links to something more concrete as "here" links in the web are basically discouraged for accessibility reasons.

@philvarner
Copy link
Collaborator Author

Looks good, but I've replaced the "here" links to something more concrete as "here" links in the web are basically discouraged for accessibility reasons.

Thanks, I just got lazy there.

@philvarner philvarner merged commit c598e13 into radiantearth:main Jan 31, 2023
@philvarner philvarner deleted the pv/more-extensions-refactor branch January 31, 2023 00:16
philvarner added a commit to philvarner/stac-api-spec that referenced this pull request Feb 2, 2023
@philvarner @m-mohr
link to STAC API Extensions site instead of listing them (radianteart…
220fedb 
…h#381)

* link to STAC API Extensions site instead of listing them

* Apply suggestions from code review

---------

Co-authored-by: Matthias Mohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mohr m-mohr m-mohr approved these changes

@cholmes cholmes Awaiting requested review from cholmes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philvarner @m-mohr