Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ref to use booleanExpression #302

Merged
merged 1 commit into from
May 24, 2022

Conversation

tschaub
Copy link
Collaborator

@tschaub tschaub commented May 24, 2022

See opengeospatial/ogcapi-features@c1c5801.

Related Issue(s):

Proposed Changes:

  1. Use booleanExpression instead of booleanValueExpression

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • A CHANGELOG entry is not required.

@tschaub tschaub mentioned this pull request May 24, 2022
4 tasks
@philvarner philvarner changed the base branch from master to dev May 24, 2022 20:29
@philvarner
Copy link
Collaborator

updated this to be against dev instead of master

@philvarner philvarner merged commit 84fb359 into radiantearth:dev May 24, 2022
@tschaub
Copy link
Collaborator Author

tschaub commented May 24, 2022

updated this to be against dev instead of master

Thanks. I based the branch on dev, but forgot that GitHub defaults to the default branch.

@tschaub tschaub deleted the boolean-expression branch May 24, 2022 20:50
@philvarner
Copy link
Collaborator

That's why we added it to the PR template checklist 😄 😢

@tschaub
Copy link
Collaborator Author

tschaub commented May 24, 2022

That's why we added it to the PR template checklist 😄 😢

Yeah, that has been enough of a reminder for me to rebase on dev after initially opening up a pull request with a branch based on master. Still, after I go through all that, I forget to also change the base branch in GitHub (I probably wrongly assumed it could figure out that my branch was based on dev and not master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants