Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify semantics of the limit parameter #220

Merged
merged 2 commits into from
Oct 13, 2021
Merged

clarify semantics of the limit parameter #220

merged 2 commits into from
Oct 13, 2021

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): #126

Proposed Changes:

  1. Clarify that the limit parameter is a recommendation (e.g., servers can ignore it and still be conformant)
  2. Clarify that the server implementer can advertise a different value than the default in the service-desc
  3. Clarify that if a value greater than the advertsized maximum is requested that the server should respond with the max rather than thrown an error.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner changed the base branch from master to dev October 11, 2021 20:26
jisantuc
jisantuc approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@jisantuc jisantuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clearer for sure

m-mohr
m-mohr approved these changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment.

@philvarner philvarner merged commit 5a98453 into radiantearth:dev Oct 13, 2021
@philvarner philvarner deleted the clarify-limit-min-and-max branch October 13, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jisantuc jisantuc jisantuc approved these changes

@m-mohr m-mohr m-mohr approved these changes

@jbants jbants Awaiting requested review from jbants

@cholmes cholmes Awaiting requested review from cholmes

@lossyrob lossyrob Awaiting requested review from lossyrob

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philvarner @jisantuc @m-mohr