-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter Extension #128
Merged
Merged
Filter Extension #128
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6d51718
initial draft for Filter extension
philvarner 3f51664
filter extension: update text with a few missing details
philvarner 1d32f24
add more details around implementation requirements
philvarner ae9db54
draft openapi spec
philvarner 26d22ce
update examples, and implementation section
philvarner facfd04
remove stray comma
philvarner e5031e8
wordsmith text
philvarner d22cda2
wordsmith text
philvarner c810d2c
wordsmith text
philvarner 7edc330
improve openapi definition
philvarner eba4135
add text about synthetic queryables
philvarner 7913862
Merge branch 'dev' into filter-extension
philvarner e8490d9
add better example, fix linting error in markdown and schemas
philvarner 518184f
fix ref to cql yml
philvarner 2bdf845
minor fixes for filter openapi
philvarner 0b115eb
Merge branch 'dev' into filter-extension
philvarner e372618
clarification on queryables, line breaks, wordsmithing
philvarner 9f9a3dd
fix formatting
philvarner 7265eb8
redefine conformance classes
philvarner 820a18e
change conformance class names back to item-search#
philvarner c201898
tweak language around proprietary extensions in queryables, add note …
philvarner 96696c4
update list of conformance class uris in extension page
philvarner 90c88da
add conformance class field to each extension
philvarner 61a1f36
fix formatting of filter conformance classes
philvarner 1fb71cb
fix formatting typo
philvarner 9acf92d
clarify queryables
philvarner b9b7c83
add a getting started section
philvarner 8e08794
modify text based on comments from Rob
philvarner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add text about synthetic queryables
- Loading branch information
commit eba41352ec9bda279ac266313bc036d2e6a6faae
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is more a justification for the extension, and perhaps doesn't need to be so prominent. It was a little confusing to me reading through the spec as I was expecting this section to begin talking about what this extensions supports. I'd recommend making a section lower down dedicated to talking about other parts of the spec in comparison or justifying this extension, and have the beginning of this document focused on specifying what the filter extension is and does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll think about that. I like having the "motivation" section first, to adequately set the stage for where we're starting with this extension.