Source map all the things #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tuff to lib that throws off coverage.
|
Source maps should now go all the way back to source. Hopefully this helps in debugging. 👍 |
|
Does this cause gobble to loop around the hardlink step for anyone else? I haven't gotten too far into it, but it looks like maybe creating a hard link in linux also triggers an fsevent on the file? |
|
Looks like I missed checking the watch. PR inbound. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request:
Configure source maps to map all the way back to the source for both library and tests.
The only real hurdle was the module-skipping code. It needed to return a source map for the replacement code in order for the mapping to be a through and through.
TODO:
Fixes the following issues:
Annoying debugging of code using the bundled version as reference.
Is breaking:
No, i think.
Reviewers:
Everyone
Dependencies
Requires #2912 to go in first. It depends on several gobblefile changes there.