Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1856 #2471

Merged
merged 3 commits into from
Mar 28, 2016
Merged

Fix #1856 #2471

merged 3 commits into from
Mar 28, 2016

Conversation

MartinKolarik
Copy link
Member

Doesn't change behavior of {{>partial context}}, as I think partial should render even if context is undefined. Thoughts?

@evs-chris
Copy link
Contributor

👍 I agree.

Also, I feel like a partial with context should not have the context portion applied around the partial so that it doesn't interfere with resolution inside the partial expression. So instead of desugaring {{>partial context}} to {{#with context}}{{>partial}}{{/with}}, move the {{#with}} into the fragment of the partial when it's set up in the virtual dom so it would end up being something like {{>partial}}{{#with context}}...partial content with 'partial' resolved in parent context...{{/with}}{{/>partial}}. It doesn't interfere too often, but when it does, it's really confusing.

I only mentioned that because I misread the opening comment and thought that's what you were saying 😄.

@MartinKolarik
Copy link
Member Author

Also, I feel like a partial with context should not have the context portion applied around the partial so that it doesn't interfere with resolution inside the partial expression.

That makes sense. I'm going to merge this, but we should probably address it in a separate PR.

@MartinKolarik MartinKolarik merged commit 5c4ab5a into dev Mar 28, 2016
@MartinKolarik MartinKolarik deleted the gh-1856 branch March 28, 2016 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants