Make sure shuffling doesn't cause index changes to propagate to levels referencing a deeper index #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evs-chris
added a commit
that referenced
this pull request
Nov 11, 2014
Make sure shuffling doesn't cause index changes to propagate to levels referencing a deeper index
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shuffling propagates new indices through child fragments, which was causing nested iterations to have their indices wiped out. In order to track which sections are iterative, this adds a
currentSubtypeto the section which gets set upon re-evaluation. ThecurrentSubtypecurrently only distinguishes betweenIF,EACH, andWITH. If rebind is called on a section that is andEACH, the index is removed (set toundefined) when rebinding its children so that the children don't get the index from upstream. TheFragment.rebindis also updated to ignoreundefinedindex changes.This fixes #1457