Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List ractive/backbone as peerDependencies #23

Merged
merged 6 commits into from
Oct 3, 2014
Merged

List ractive/backbone as peerDependencies #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ecc1c7a
Test ractive 0.4.0 support
rstacruz Oct 3, 2014
bf9b5bb
List backbone and ractive as a peer dependency
rstacruz Oct 3, 2014
8e6c762
Update changelog
rstacruz Oct 3, 2014
46b5ef7
Add notes on how to use this with npm/browserify
rstacruz Oct 3, 2014
1a69ce2
Also add ractive as a peerDependency
rstacruz Oct 3, 2014
f628c2e
List backbone as devDependency
rstacruz Oct 3, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@

* Internal: update test suite to Mocha. (@rstacruz, #17, #18)

* List Backbone and Ractive as peer dependencies. (@rstacruz, #19)

* Update required versions of Backbone and Ractive to allow future versions.
(@rstacruz, #19)

## v0.1.1 - June 9, 2014

* BREAKING CHANGE: Rename to `ractive-adaptors-backbone`.
Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ To get `ractive-adaptors-backbone.min.js` you can:

$ bower i ractive-backbone

#### Use npm

$ npm install --save-dev ractivejs/ractive-adaptors-backbone

#### Download

- [Download the latest release](https://github.com/ractivejs/ractive-adaptors-backbone/releases).
Expand Down
8 changes: 5 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,17 @@
"type": "git",
"url": "https://github.com/ractivejs/ractive-adaptors-backbone.git"
},
"dependencies": {
"backbone": "~1.1.0",
"ractive": "~0.3.9"
"peerDependencies": {
"backbone": ">= 1.0.0",
"ractive": ">= 0.3.9"
},
"scripts": {
"test": "mocha",
"coverage": "(cp ractive-adaptors-backbone.js ractive-adaptors-backbone.js~; jscoverage ractive-adaptors-backbone.js; mv ractive-adaptors-backbone-cov.js ractive-adaptors-backbone.js; mocha -R html-cov > coverage.html); mv ractive-adaptors-backbone.js~ ractive-adaptors-backbone.js",
"prepublish": "grunt"
},
"devDependencies": {
"backbone": ">= 1.0.0",
"chai": "^1.9.2",
"grunt": "~0.4.1",
"grunt-cli": "^0.1.13",
Expand All @@ -38,6 +39,7 @@
"mocha-clean": "^0.2.1",
"mocha-repeat": "^0.1.0",
"proxyquire": "^1.0.1",
"ractive": ">= 0.3.9",
"underscore": "^1.7.0"
}
}
9 changes: 8 additions & 1 deletion test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ var libs = {
'0.6.0': require( '../vendor/ractive/ractive-edge.js' ),
'0.5.8': require( '../vendor/ractive/ractive-0.5.8.js' ),
'0.5.0': require( '../vendor/ractive/ractive-0.5.0.js' ),
'0.4.0': require( '../vendor/ractive/ractive-0.4.0.js' ),
},
backbone: {
'1.1.2': require( '../vendor/backbone/backbone-1.1.2.js' ),
Expand Down Expand Up @@ -88,7 +89,13 @@ tests( 'Ractive-adaptors-backbone', function ( Ractive, Backbone ) {
describe( 'models', function () {
beforeEach(function () {
model = new Backbone.Model();
ractive = new Ractive();
});

beforeEach(function () {
if (Ractive.VERSION === '0.4.0')
ractive = new Ractive({ adaptor: '' });
else
ractive = new Ractive();
});

it( 'works', function () {
Expand Down
Loading