Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ractive and backbone need to be peer dependencies #19

Closed
rstacruz opened this issue Sep 30, 2014 · 2 comments · Fixed by #23
Closed

ractive and backbone need to be peer dependencies #19

rstacruz opened this issue Sep 30, 2014 · 2 comments · Fixed by #23

Comments

@rstacruz
Copy link
Contributor

ractive and backbone need to be under peerDependencies.

It might not work in browserify otherwise. x instanceof Backbone.Model may check x against a new instance of Backbone from the one the user's probably already using.
@rstacruz
Copy link
Contributor Author

rstacruz commented Oct 2, 2014

oh, and it's probably a good idea to change their versions to ractive >= 0.4.0 and backbone >= 1.0.0.

@rstacruz rstacruz mentioned this issue Oct 3, 2014
Merged
rstacruz added a commit that referenced this issue Oct 3, 2014
@rstacruz
Merge pull request #23 from ractivejs/gh-19
4471813 
List ractive/backbone as peerDependencies
@Rich-Harris
Copy link
Member

Ah, I finally understand peerDependencies! Nice one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

List ractive/backbone as peerDependencies ractivejs/ractive-adaptors-backbone
2 participants
@rstacruz @Rich-Harris