Support for period ranges

[flevour]

Supports range based periods, for the cases when periods needs to be manually defined such as start/end of the month or any particularly different metric.

period_based_on_proc = proc {|req| (Time.now.gmtime.beginning_of_month..Time.now.gmtime.end_of_month) }
Rack::Attack.throttle('req/ip', :limit => 100, :period => period_based_on_proc) do |req|
  req.ip
end

[zmillman]

I'm skeptical about how useful this would be to 95% of rack-attack users would find helpful. (Is this feature worth the extra complexity?)

Do you have a specific use-case in mind?

[flevour]

@zmillman in my case I 'm using rack-attack to throttle access to an API.
The API plans allow a given amount of monthly requests where a month is a defined as a calendar month starting at midnight of 1st day and ending at midnight of last day.
Time.now.to_i/1.month doesn't give the same precision in terms of reset date.

On a second thought, instead of a range, I could change the logic to support an :until => Time option that could be used in place of :period.
WDYT?

[ktheory]

Thanks for this PR, @flevour. 😺

I agree with @zmillman that this is not generally useful as currently implemented with ranges.

The simplest change to support your use case is to make period take a proc. Then you can do period: -> { (Time.now.end_of_month - Time.now).to_i }.

This is similar to how the limit option works.

Gonna close this for now. Feel free to update to make period take a proc.