Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support delete method for Redis #119

Merged
merged 1 commit into from
Apr 16, 2015
Merged

Conversation

stanhu
Copy link
Contributor

@stanhu stanhu commented Mar 15, 2015

Delete the key outright to support #113

@stanhu stanhu force-pushed the add-delete-interface branch from 4d8a395 to a2ef771 Compare March 15, 2015 19:12
@stanhu stanhu force-pushed the add-delete-interface branch from a2ef771 to ff15447 Compare March 15, 2015 19:13
@ktheory
Copy link
Collaborator

ktheory commented Apr 16, 2015

Seems fine. @zmillman: what do you think?

@zmillman
Copy link
Contributor

Looks good to me 👍

It was silly that Rack::Attack has delete for Dalli, but not for Redis

ktheory added a commit that referenced this pull request Apr 16, 2015
@ktheory ktheory merged commit 0ec73d9 into rack:master Apr 16, 2015
@ktheory
Copy link
Collaborator

ktheory commented Apr 16, 2015

@stanhu mind giving commit 3e0fcc2 a try, and I'll cut a release in the next few days?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants