Pass raw: true to prevent Ruby de/serialization. This is to make it po...
#118
Conversation
… possible to implement something like: ```store.write(key, 0, :expires_in => expires_in)``` See rack#113
|
Is it better to pass options to both |
|
@stanhu: looks good. thanks. |
Pass `raw: true` to prevent Ruby de/serialization. This is to make it po...
|
@stanhu: Is this going to cause errors when deployed? E.g., an app has a bunch of marshalled values in redis already. When they deploy this update, Rack::Attack will read them as raw values instead. |
|
@ktheory, yes it is a potential issue. We could make it default to marshalled values and use the options to override this behavior. But there is an inconsistency already in that the |
|
@stanhu: ok, so the only time Rack::Attack So it seems like this is strictly an improvement; not a gotcha for any redis users. 😄 |
|
@ktheory: Right, thanks! |
...ssible
to implement something like:
store.write(key, 0, :expires_in => expires_in)See #113