Add ability to upload image handouts #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #254 +/- ##
==========================================
+ Coverage 85.08% 85.15% +0.06%
==========================================
Files 41 41
Lines 2548 2560 +12
Branches 26 26
==========================================
+ Hits 2168 2180 +12
Misses 379 379
Partials 1 1
Continue to review full report at Codecov.
|
z4y4ts
reviewed
Jul 11, 2017
| @@ -240,11 +240,14 @@ function createTranscriptBlock(langCode, langLabel, transcriptsValue, downloadTr | |||
| */ | |||
| function clickUploader(event, $fileUploader) { | |||
| 'use strict'; | |||
| var handoutsAllowedFileTypes = '.png, .jpeg, .jpg, .gif, .tiff'; | |||
There was a problem hiding this comment.
Please check what types stock open edx video xmodule supports.
I'm certain this list should include .pdf, and maybe some more.
There was a problem hiding this comment.
z4y4ts
approved these changes
Jul 12, 2017
wowkalucky
added a commit
that referenced
this pull request
Aug 3, 2017
* Add ability to upload image handouts * Extend handouts allowed file types list * Refactor uploading file extension check, cover it with unittests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to allow uploading images as handouts. Size limit is still 300Kb.