Cover html5 backend with unit tests #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: Move basic & advanced fields declaration to BaseVideoPlayer, remove editable_fields (#164) # Conflicts: # video_xblock/tests/test_backends.py
Codecov Report
@@ Coverage Diff @@
## dev #167 +/- ##
=========================================
+ Coverage 69.4% 69.47% +0.06%
=========================================
Files 26 26
Lines 1510 1510
Branches 9 9
=========================================
+ Hits 1048 1049 +1
+ Misses 460 459 -1
Partials 2 2
Continue to review full report at Codecov.
|
z4y4ts
added a commit
that referenced
this pull request
Mar 31, 2017
* dev: Remove TinyMCE related code from studio-edit.js (#142) Fix few frontend bugs slipped in after code restructuring (#184) Update 0.6.3 details in CHANGELOG.md Extend Brightcove url regex to include additional set of video urls (#182) Refactoring/improve js (#162) Switch to master branch of raccoongang/videojs-wistia (#180) Add 0.6.1 release to CHANGELOG.md and fix typo in README.md (#179) Change make deps-test dependency for faster CI builds (#177) Move all external JS and CSS files into video_xblock/static/vendor dir (#176) Cover html5 backend with unit tests (#167) Add SettingsMixin and default values population from config files (#175) Fixes after code review (#174)
z4y4ts
added a commit
that referenced
this pull request
Apr 15, 2017
* dev: Remove TinyMCE related code from studio-edit.js (#142) Fix few frontend bugs slipped in after code restructuring (#184) Update 0.6.3 details in CHANGELOG.md Extend Brightcove url regex to include additional set of video urls (#182) Refactoring/improve js (#162) Switch to master branch of raccoongang/videojs-wistia (#180) Add 0.6.1 release to CHANGELOG.md and fix typo in README.md (#179) Change make deps-test dependency for faster CI builds (#177) Move all external JS and CSS files into video_xblock/static/vendor dir (#176) Cover html5 backend with unit tests (#167) Add SettingsMixin and default values population from config files (#175) Fixes after code review (#174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.