expose store_offset and query_offset in consumer #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 88.17% 88.56% +0.38%
==========================================
Files 68 68
Lines 5625 5650 +25
==========================================
+ Hits 4960 5004 +44
+ Misses 665 646 -19
☔ View full report in Codecov by Sentry. |
DanielePalaia
force-pushed
the
store_offset_exposed
branch
3 times, most recently
from
0d376e4 to
52c1278
Compare
DanielePalaia
force-pushed
the
store_offset_exposed
branch
2 times, most recently
from
5577acf to
d73ffb3
Compare
DanielePalaia
force-pushed
the
store_offset_exposed
branch
from
d73ffb3 to
0ce70ae
Compare
Gsantomaggio
requested changes
Oct 23, 2023
|
@Gsantomaggio Sure! Done!! |
|
Can you add a test using a real offset coming form the chunk ? |
|
Done! |
Gsantomaggio
approved these changes
Oct 25, 2023
wolf4ood
approved these changes
Oct 25, 2023
src/consumer.rs
Outdated
Comment on lines
153
to
172
| pub async fn store_offset(&self, offset: u64) -> Result<(), ConsumerStoreOffsetError> { | ||
| if self.name.is_none() { | ||
| return Err(ConsumerStoreOffsetError::NameMissing); | ||
| } | ||
|
|
||
| let result = self | ||
| .internal | ||
| .client | ||
| .store_offset( | ||
| self.name.clone().unwrap().as_str(), | ||
| self.internal.stream.as_str(), | ||
| offset, | ||
| ) | ||
| .await; | ||
|
|
||
| match result { | ||
| Ok(()) => Ok(()), | ||
| Err(e) => Err(ConsumerStoreOffsetError::Client(e)), | ||
| } | ||
| } |
There was a problem hiding this comment.
You could make it a little bit shorter like this:
Suggested change
| pub async fn store_offset(&self, offset: u64) -> Result<(), ConsumerStoreOffsetError> { | |
| if self.name.is_none() { | |
| return Err(ConsumerStoreOffsetError::NameMissing); | |
| } | |
| let result = self | |
| .internal | |
| .client | |
| .store_offset( | |
| self.name.clone().unwrap().as_str(), | |
| self.internal.stream.as_str(), | |
| offset, | |
| ) | |
| .await; | |
| match result { | |
| Ok(()) => Ok(()), | |
| Err(e) => Err(ConsumerStoreOffsetError::Client(e)), | |
| } | |
| } | |
| pub async fn store_offset(&self, offset: u64) -> Result<(), ConsumerStoreOffsetError> { | |
| if let Some(name) = &self.name { | |
| self.internal | |
| .client | |
| .store_offset(name, self.internal.stream.as_str(), offset) | |
| .await | |
| .map(Ok)? | |
| } else { | |
| Err(ConsumerStoreOffsetError::NameMissing) | |
| } | |
| } |
same for query_offset.
|
@Gsantomaggio and @wolf4ood for the review! I also implemented the last suggestion as having more compact code is better! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #195
Exposes store_offset and query_offset in Consumer struct