Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compressions #97

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Implement compressions #97

merged 1 commit into from
Oct 29, 2021

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Oct 29, 2021

fixes: #91
pair with @MarcialRosales

This PR replace #93.

Closes #91

Most of the job is done by @MarcialRosales.

@Gsantomaggio Gsantomaggio mentioned this pull request Oct 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #97 (9ed874d) into main (48e5027) will decrease coverage by 1.13%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   80.63%   79.49%   -1.14%     
==========================================
  Files          16       16              
  Lines        2282     2390     +108     
==========================================
+ Hits         1840     1900      +60     
- Misses        333      357      +24     
- Partials      109      133      +24     
Impacted Files Coverage Δ
pkg/stream/aggregation.go 62.89% <55.55%> (-15.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e5027...9ed874d. Read the comment docs.

@Gsantomaggio Gsantomaggio merged commit cb4929a into main Oct 29, 2021
@Gsantomaggio Gsantomaggio deleted the add_compressions_type branch October 29, 2021 09:43
Zerpet added a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 3 more compression algorithms
2 participants