Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure connection settings via EnvironmentOptions #94

Merged
merged 13 commits into from
Oct 29, 2021
Merged

Conversation

MarcialRosales
Copy link
Collaborator

@MarcialRosales MarcialRosales commented Oct 28, 2021

Closes #90

@codecov-commenter
Copy link

Codecov Report

Merging #94 (1c1221a) into main (52d2271) will decrease coverage by 1.47%.
The diff coverage is 41.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   81.69%   80.21%   -1.48%     
==========================================
  Files          16       16              
  Lines        2245     2295      +50     
==========================================
+ Hits         1834     1841       +7     
- Misses        305      343      +38     
- Partials      106      111       +5     
Impacted Files Coverage Δ
pkg/stream/client.go 80.76% <35.29%> (-0.40%) ⬇️
pkg/stream/enviroment.go 70.13% <36.36%> (-4.74%) ⬇️
pkg/stream/brokers.go 84.70% <100.00%> (-4.19%) ⬇️
pkg/stream/server_frame.go 81.93% <0.00%> (-1.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d2271...1c1221a. Read the comment docs.

@Gsantomaggio Gsantomaggio merged commit 48e5027 into main Oct 29, 2021
@Gsantomaggio Gsantomaggio deleted the 90-issue branch October 29, 2021 07:33
@Gsantomaggio Gsantomaggio changed the title 90 issue Configure connection settings via EnvironmentOptions Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure connection settings via EnvironmentOptions
3 participants