Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer improvements for 1.5 #371

Merged
merged 18 commits into from
Jan 14, 2025
Merged

Consumer improvements for 1.5 #371

merged 18 commits into from
Jan 14, 2025

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Jan 9, 2025 •
edited
Loading

  • Refactor the consumer to deal with some edge case whit the metadata update
  • Aggregate the confirmation responses to be faster during the unconfirmed extraction
  • refactor the message sequence struct to remove the reference to the original message ( it could increase the memory usage in some case )

@Gsantomaggio
wip
1bf978b 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
wip
c3c52cb 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
wip
09ef07a 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
temp calculation
8b3c4a1 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
add function to process the messages
b4563a8 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
add function to process the messages
6a1e0f9 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
aggregate responses
3374ca6 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
restore timeout
d9ac9ac 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
tmp buffer
948dc30 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
add pool
62d6125 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
rename
9ff963f 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
remove loop
811d615 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
restore map
df586f3 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
logs
729e156 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
restore dynamic batch
101a3d2 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
clean the consumer buffer in case the consumer does not exist
d71bb84 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
make the handler mandatory
eff30cf 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio added this to the 1.5.0 milestone Jan 14, 2025
@Gsantomaggio Gsantomaggio marked this pull request as ready for review January 14, 2025 10:53
@Gsantomaggio
remove unsed code
57be0d3 
Signed-off-by: Gabriele Santomaggio <[email protected]>
hiimjako
hiimjako approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@hiimjako hiimjako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a cluster, and the reconnection issues have been resolved. I've also noticed a latency improvement of approximately 2-3ms compared to version 1.4.11.

@Gsantomaggio Gsantomaggio merged commit 31dbf96 into main Jan 14, 2025
4 checks passed
@Gsantomaggio Gsantomaggio deleted the consumer_improve_1_5 branch January 14, 2025 12:44
@Gsantomaggio Gsantomaggio mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiimjako hiimjako hiimjako approved these changes

Assignees

@hiimjako hiimjako

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gsantomaggio @hiimjako