Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange version - Step 1 #278

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Exchange version - Step 1 #278

merged 2 commits into from
Mar 19, 2024

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Mar 19, 2024

Prepare for exchange version command.
Read the server side properties
Add Available Features

work in progress

Signed-off-by: Gabriele Santomaggio <[email protected]>
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.40%. Comparing base (4d96707) to head (cc77d6b).

Files Patch % Lines
pkg/stream/client.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   80.19%   80.40%   +0.21%     
==========================================
  Files          21       22       +1     
  Lines        2918     2981      +63     
==========================================
+ Hits         2340     2397      +57     
- Misses        416      422       +6     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio marked this pull request as ready for review March 19, 2024 15:15
@Gsantomaggio Gsantomaggio merged commit 04f8336 into main Mar 19, 2024
7 checks passed
@Gsantomaggio Gsantomaggio deleted the exchange_version branch March 19, 2024 15:26
@Gsantomaggio Gsantomaggio changed the title Exchange version Exchange version - Step 1 Mar 20, 2024
@Gsantomaggio Gsantomaggio added this to the 1.3.3 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant