Fixes #158 #159
Merged
Fixes #158 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 17 17
Lines 2575 2570 -5
=======================================
- Hits 2062 2058 -4
+ Misses 371 370 -1
Partials 142 142
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Zerpet
changed the title
Closed
Zerpet
reviewed
Aug 5, 2022
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
Zerpet
force-pushed
the
fix_wrong_offset
branch
from
9dfea91 to
f492854
Compare
|
Rebased main branch to resolve conflicts. I will do a refactor before marking this ready. |
Related to #158 Signed-off-by: Aitor Perez Cedres <[email protected]>
|
Marking as ready for review after adding a test case for the fix. @Gsantomaggio do you want to review the test case once CI passes? |
|
@Zerpet looks good to me! ty! |
|
Will it be released recently? |
|
Thank you, i'll have a try |
|
Can you try this code? The message with offset 100 is missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gabriele Santomaggio [email protected]
The PR fixes the wrong offset stored.
It is in draft since tests are missing.