Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store custom offset #125

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Store custom offset #125

merged 2 commits into from
Feb 21, 2022

Conversation

MarcialRosales
Copy link
Collaborator

@MarcialRosales MarcialRosales commented Feb 21, 2022

Up until now we could only commit the last delivered message in case of manual offset tracking and automatically, after N messages or after N unit of time.

However, there are scenarios where we need to commit a given offset, not necessarily the very last delivered offset. This is specially necessary when we process messages in the background, outside of the message handler method.

Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the documentation on the REAME.md file about that?

@MarcialRosales
Copy link
Collaborator Author

MarcialRosales commented Feb 21, 2022

Can you please add the documentation on the REAME.md file about that?

Absolutely. But I think I will also add an example as we do with other features. Thanks!

@Gsantomaggio
Copy link
Member

But I think I will also add an example as we do with other features.

Great :)!

@codecov-commenter
Copy link

Codecov Report

Merging #125 (8c860f2) into main (d8131c3) will increase coverage by 0.53%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   79.82%   80.36%   +0.53%     
==========================================
  Files          16       16              
  Lines        2493     2500       +7     
==========================================
+ Hits         1990     2009      +19     
+ Misses        367      355      -12     
  Partials      136      136              
Impacted Files Coverage Δ
pkg/stream/consumer.go 77.38% <93.33%> (+0.30%) ⬆️
pkg/stream/server_frame.go 83.59% <0.00%> (+1.54%) ⬆️
pkg/stream/client.go 83.60% <0.00%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8131c3...8c860f2. Read the comment docs.

@Gsantomaggio Gsantomaggio merged commit 976b95d into main Feb 21, 2022
@Gsantomaggio Gsantomaggio deleted the commit-given-offset branch February 21, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants