Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastconsumed when no offset #122

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Lastconsumed when no offset #122

merged 6 commits into from
Feb 18, 2022

Conversation

MarcialRosales
Copy link
Collaborator

When we susbcribe to a stream for the first time with a named consumer and with LastConsumed offset, we get the error "19 No Offset" from the broker.

We should not throw the error but instead default lastOffset to 0.

@codecov-commenter
Copy link

Codecov Report

Merging #122 (d1ddf2e) into main (0b47773) will increase coverage by 0.28%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   79.70%   79.98%   +0.28%     
==========================================
  Files          16       16              
  Lines        2488     2488              
==========================================
+ Hits         1983     1990       +7     
+ Misses        367      359       -8     
- Partials      138      139       +1     
Impacted Files Coverage Δ
pkg/stream/constants.go 65.57% <0.00%> (-2.23%) ⬇️
pkg/stream/client.go 81.74% <50.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b47773...d1ddf2e. Read the comment docs.

@Gsantomaggio Gsantomaggio merged commit 1af5ee1 into main Feb 18, 2022
@Gsantomaggio Gsantomaggio deleted the lastconsumed_when_no_offset branch February 18, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants