Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a limit to the unconfirmed list #373

Closed
Gsantomaggio opened this issue Jan 16, 2025 · 0 comments · Fixed by #378
Closed

Add a limit to the unconfirmed list #373

Gsantomaggio opened this issue Jan 16, 2025 · 0 comments · Fixed by #378
Labels
enhancement New feature or request

Comments

@Gsantomaggio
Copy link
Member

Is your feature request related to a problem? Please describe.

at the moment, the list is unbounded the memory could grow without control

Describe the solution you'd like

add a limit and block the send when the limit is reached.

Describe alternatives you've considered

No response

Additional context

No response
@Gsantomaggio Gsantomaggio added the enhancement New feature or request label Jan 16, 2025
Gsantomaggio added a commit that referenced this issue Jan 27, 2025
@Gsantomaggio
Add limit to the unconfirmed messages
a2b570a 
The producer is blocked when the limit is reached. It is possible to configure the
limit using the producerOption.QueueSize setting.

Closes: #373

Close the TCP client connection in case of CRC fail. The panic is removed.
Closes: #368

Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio mentioned this issue Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add limit to the unconfirmed messages rabbitmq/rabbitmq-stream-go-client
1 participant
@Gsantomaggio