Handle too many heart missing with reconnection #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close from normal to Unexpected. Fixes: #393 Signed-off-by: Gabriele Santomaggio <[email protected]>
|
@bastl98 can you please try the PR? the client should reconnect producer and consumer |
Signed-off-by: Gabriele Santomaggio <[email protected]>
to the Connection class. Remove the update status form the the Dispose() function. It is not necessary since the dispose can be called only from the Client close() function where the status is set. Add a function to convert the connetion close reason string to the Reliable.ChangeStatusReason Enum. This mapping should be improved to the version 2.0 where we can introduce some breaking changes. In the version 1.x we need the conversion function. Signed-off-by: Gabriele Santomaggio <[email protected]>
Gsantomaggio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close from normal to Unexpected.
Fixes: #393
Changes:
Remove the update status form the the Dispose() function.
It is unnecessary since the disposal can be called only from the Client close() function
where the status is set.
Add a function to convert the connection close reason string to the Reliable.ChangeStatusReason Enum.
This mapping should be improved to version 2.0, where we can introduce breaking changes.
In version 1.x, we need the conversion function.