This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
Terminate STOMP processor when reader exits due to an exception #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why not just link the two? Then any network-related issue would produce a scary crash report in the SASL log and we won't give the processor some time to finish what it may still be doing. Fixes #7.
dumbbell
force-pushed
the
rabbitmq-stomp-7
branch
from
adad91f to
e7ab526
Compare
dumbbell
added a commit
that referenced
this pull request
Apr 8, 2015
Terminate STOMP processor when reader exits due to an exception
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7.
When we encounter a socket or parsing error, we need to make sure to shoot down processor. Otherwise we leak direct Erlang client connections. Which in turn exposed interesting edge cases such as rabbitmq/rabbitmq-management#29.
Some background on why we fix it in this particular way:
So linking won't work.
To test this manually, connect to the server via netcat as explained in the STOMP plugin documentation but after sending a
CONNECTframe, send some garbage and a few new lines. You will see a parsing error in the log.For 3.6.0 we will refactor STOMP plugin to only have one process (à la MQTT).