Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert elixir json switch #9952

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Revert elixir json switch #9952

merged 7 commits into from
Nov 20, 2023

Conversation

mkuratczyk
Copy link
Contributor

@mkuratczyk mkuratczyk commented Nov 17, 2023

Unfortunately the switch to rabbit_json/thoas led to some commands failing:

> rabbitmqctl list_stream_connections --formatter json conn_name
[
{"conn_name":"127.0.0.1:60556 -> 127.0.0.1:5552"}
,{"conn_name":"127.0.0.1:60552 -> 127.0.0.1:5552"}
,{"conn_name":"127.0.0.1:60555 -> 127.0.0.1:5552"}
]

> rabbitmqctl list_stream_connections --formatter json conn_name,client_properties
[
{:badmatch, {:error, :function_clause}}

We'll look into this at some point. For now, let's revert.

References #9926 #9932.

@mkuratczyk mkuratczyk marked this pull request as ready for review November 20, 2023 08:32
@michaelklishin michaelklishin merged commit 8d9ce84 into main Nov 20, 2023
@michaelklishin michaelklishin deleted the revert-elixir-json-switch branch November 20, 2023 11:45
michaelklishin added a commit that referenced this pull request Nov 20, 2023
michaelklishin added a commit that referenced this pull request Nov 20, 2023
michaelklishin added a commit that referenced this pull request Nov 20, 2023
mergify bot pushed a commit that referenced this pull request Nov 20, 2023
(cherry picked from commit afe2a63)
michaelklishin added a commit that referenced this pull request Nov 21, 2023
Revert elixir json switch (backport #9952) (backport #9957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants