[OCF HA] Add ocf_get_private_attr function to RabbitMQ OCF script #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| if [ $? -ne 0 ]; then | ||
| echo $attr_default_value | ||
| else | ||
| echo "$count" | awk '{ gsub(/"/, "", $3); split($3, vals, "="); if (vals[2] != "(null)") print vals[2] }' |
There was a problem hiding this comment.
Shouldn't (null) be transformed to $attr_default_value?
The function is extracted from check_timeouts to be re-used later in other parts of the script. Also, swtich check_timeouts to use existing ocf_update_private_attr function.
dmitrymex
force-pushed
the
get-private-attr
branch
from
73899b3 to
39a5faf
Compare
|
@binarin: yep, probably a good idea :-) Fixed that. |
openstack-gerrit
pushed a commit
to openstack-archive/fuel-library
that referenced
this pull request
Aug 19, 2016
The function is extracted from check_timeouts to be re-used later in other parts of the script. Also, swtich check_timeouts to use existing ocf_update_private_attr function. Upstream PR: rabbitmq/rabbitmq-server#926 Change-Id: Iaae9e4a06879e7e5b716591d9e2d69a5b34f6422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is extracted from check_timeouts to be re-used later
in other parts of the script. Also, swtich check_timeouts to use
existing ocf_update_private_attr function.