Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #8547 #8548

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Fixes #8547 #8548

merged 1 commit into from
Jun 14, 2023

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Jun 13, 2023 •
edited
Loading

Only configure oauth2's http client with ssl option cacertfile when there is a value for it. Since OTP 26, http client does not support undefined values in cacertfile.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this Jun 13, 2023
@MarcialRosales MarcialRosales force-pushed the fix-8547 branch 2 times, most recently from 1d428c4 to 8e072e8 Compare June 14, 2023 07:36
@MarcialRosales MarcialRosales marked this pull request as ready for review June 14, 2023 07:36
@michaelklishin michaelklishin added this to the 3.12.1 milestone Jun 14, 2023
@michaelklishin michaelklishin merged commit e87abc0 into main Jun 14, 2023
@michaelklishin michaelklishin deleted the fix-8547 branch June 14, 2023 10:39
@mergify mergify bot mentioned this pull request Jun 14, 2023
Merged
michaelklishin added a commit that referenced this pull request Jun 14, 2023
@michaelklishin
Merge pull request #8566 from rabbitmq/mergify/bp/v3.12.x/pr-8548
1f852a3 
Fixes #8547 (backport #8548)
michaelklishin added a commit that referenced this pull request Jun 14, 2023
@michaelklishin
Merge pull request #8572 from rabbitmq/mergify/bp/v3.11.x/pr-8566
8f39150 
Fixes #8547 (backport #8548) (backport #8566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@MarcialRosales MarcialRosales

Labels
None yet
Projects
None yet
Milestone
3.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcialRosales @michaelklishin