Fix quorum queue queue federation bugs (backport #8282) #8328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Quorum queues would due to a misunderstanding whilst porting queue decorators from classic queues calculate the wrong maximum consumer priority leading to strange behaviour when using queue federation. Also notify decorators on startup. In this case we had to do this when a member becomes leader which isn't always at startup so will have to rely on the mirroried supervisor to ensure we don't start multiple federation links. (cherry picked from commit 21b9eb5)
around federated queue link state transitions (pause/unpause). References #8297. (cherry picked from commit 958043c)
michaelklishin
added a commit
that referenced
this pull request
Jan 4, 2024
That PR had no milestone set and this important change has slipped through the cracks.
michaelklishin
added a commit
that referenced
this pull request
Jan 4, 2024
That PR had no milestone set and this important change has slipped through the cracks. (cherry picked from commit 36c7d26)
michaelklishin
added a commit
that referenced
this pull request
Jan 31, 2024
That PR had no milestone set and this important change has slipped through the cracks.
michaelklishin
added a commit
that referenced
this pull request
Feb 1, 2024
That PR had no milestone set and this important change has slipped through the cracks.
michaelklishin
added a commit
that referenced
this pull request
Feb 29, 2024
That PR had no milestone set and this important change has slipped through the cracks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #8282 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com