-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to configure per-node runtime parameter limits #7917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
Configure per-host runtime parameters limit
Configure per-vhost runtime parameter limits
Apr 18, 2023
michaelklishin
changed the title
Configure per-vhost runtime parameter limits
Configure per-host runtime parameter limits
Apr 18, 2023
michaelklishin
requested changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use more realistic parameter names in tests, and clarify what exactly "host" means
in the message, e.g. is it a virtual host? a node?
michaelklishin
changed the title
Configure per-host runtime parameter limits
Configure per-node runtime parameter limits
Apr 18, 2023
michaelklishin
changed the title
Configure per-node runtime parameter limits
Make it possible to configure per-node runtime parameter limits
Apr 18, 2023
michaelklishin
approved these changes
Apr 18, 2023
michaelklishin
added a commit
that referenced
this pull request
Apr 18, 2023
Make it possible to configure per-node runtime parameter limits (backport #7917)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Introduces an arbitrary per-host runtime parameter limit, e.g.
The limit can be set to any value, negative integers treated as "unlimited". There are no sanity checks, and I expect it to be used only by power-users.
Main purpose is resource management per #7856, although this hypothetically can be used to disable certain broker features outright.
Types of Changes
Checklist
CONTRIBUTING.md
document