Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to configure per-node runtime parameter limits #7917

Merged
merged 6 commits into from
Apr 18, 2023

Conversation

illotum
Copy link

@illotum illotum commented Apr 18, 2023

Proposed Changes

Introduces an arbitrary per-host runtime parameter limit, e.g.

runtime_parameters.limits.shovel = 0
runtime_parameters.limits.federation = 100

The limit can be set to any value, negative integers treated as "unlimited". There are no sanity checks, and I expect it to be used only by power-users.

Main purpose is resource management per #7856, although this hypothetically can be used to disable certain broker features outright.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

@mergify mergify bot added the bazel label Apr 18, 2023
@michaelklishin michaelklishin changed the title Configure per-host runtime parameters limit Configure per-vhost runtime parameter limits Apr 18, 2023
@michaelklishin michaelklishin changed the title Configure per-vhost runtime parameter limits Configure per-host runtime parameter limits Apr 18, 2023
Copy link
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use more realistic parameter names in tests, and clarify what exactly "host" means
in the message, e.g. is it a virtual host? a node?

deps/rabbit/test/config_schema_SUITE_data/rabbit.snippets Outdated Show resolved Hide resolved
deps/rabbit/src/rabbit_runtime_parameters.erl Outdated Show resolved Hide resolved
@michaelklishin michaelklishin changed the title Configure per-host runtime parameter limits Configure per-node runtime parameter limits Apr 18, 2023
@michaelklishin michaelklishin changed the title Configure per-node runtime parameter limits Make it possible to configure per-node runtime parameter limits Apr 18, 2023
@michaelklishin michaelklishin disabled auto-merge April 18, 2023 06:37
@michaelklishin michaelklishin merged commit 5f342cf into rabbitmq:main Apr 18, 2023
michaelklishin added a commit that referenced this pull request Apr 18, 2023
Make it possible to configure per-node runtime parameter limits (backport #7917)
michaelklishin added a commit that referenced this pull request Apr 18, 2023
Make it possible to configure per-node runtime parameter limits (backport #7917) (backport #7920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants