Streams: make at-most-once dead lettering work #7846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously osiris did not support uncorrelated writes which means we could not use a "stateless" queue type delivery and these were silently dropped. This had the impact that at-most-once dead letter was not possible where the dead letter target is a stream. This change bumps the osiris version that has the required API to allow for uncorrelated writes (osiris:write/2). Currently there is no feature flag to control this as osiris writer processes just logs and drops any messages they don't understand.
kjnilsson
force-pushed
the
stream-at-most-once-dead-lettering
branch
from
58a430c to
e7d7f6f
Compare
acogoluegnes
approved these changes
Apr 5, 2023
michaelklishin
changed the title
michaelklishin
added a commit
that referenced
this pull request
Apr 5, 2023
Streams: make at-most-once dead lettering work (backport #7846)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously osiris did not support uncorrelated writes which means we could not use a "stateless" queue type delivery and these were silently dropped.
This had the impact that at-most-once dead letter was not possible where the dead letter target is a stream.
This change bumps the osiris version that has the required API to allow for uncorrelated writes (osiris:write/2).
Currently there is no feature flag to control this as osiris writer processes just logs and drops any messages they don't understand.