Take credits for inactive stream subscription #7638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not taking the credits can starve the subscription, making it permanently under its credit send limit. The subscription then never dispatches messages when it becomes active again. This happens in an active-inactive-active cycle, especially with slow consumers.
kjnilsson
approved these changes
Mar 16, 2023
acogoluegnes
deleted the
stream-take-credit-even-for-inactive-subscription
branch
acogoluegnes
added a commit
that referenced
this pull request
Mar 16, 2023
Take credits for inactive stream subscription (backport #7638)
acogoluegnes
added a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Mar 16, 2023
No new messages could arrive because of credit starvation, as credit providing request were not taking into account for inactive subscription. This tests a server-side fix. The test is disabled for now. References rabbitmq/rabbitmq-server#7638
github-actions bot
pushed a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Mar 16, 2023
No new messages could arrive because of credit starvation, as credit providing request were not taking into account for inactive subscription. This tests a server-side fix. The test is disabled for now. References rabbitmq/rabbitmq-server#7638
acogoluegnes
added a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Mar 23, 2023
References rabbitmq/rabbitmq-server#7638
github-actions bot
pushed a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Mar 23, 2023
References rabbitmq/rabbitmq-server#7638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not taking the credits can starve the subscription, making it permanently under its credit send limit.
The subscription then never dispatches messages when it becomes active again.
This happens in an active-inactive-active cycle, especially with slow consumers.