Quorum queues: chunk consumer log effects #7175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
kjnilsson
force-pushed
the
qq-chunk-consumer-log-effects
branch
from
6f1b819 to
b9bfe0a
Compare
kjnilsson
changed the title
ansd
reviewed
Feb 6, 2023
kjnilsson
force-pushed
the
qq-chunk-consumer-log-effects
branch
from
b9bfe0a to
7a949a6
Compare
ansd
previously approved these changes
Feb 7, 2023
kjnilsson
force-pushed
the
qq-chunk-consumer-log-effects
branch
3 times, most recently
from
2ef9f3d to
ede4f67
Compare
This puts a limit to the amount of message data that is added to the process heap at the same time to around 128KB. Large prefetch values combined with large messages could cause excessive garbage collection work. Also similify the intermediate delivery message format to avoid allocations that aren't necessary.
kjnilsson
force-pushed
the
qq-chunk-consumer-log-effects
branch
from
ede4f67 to
448ffd1
Compare
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
This puts a limit to the amount of message data that is added to the process heap at the same time to around 128KB. Large prefetch values combined with large messages could cause excessive garbage collection work. Also similify the intermediate delivery message format to avoid allocations that aren't necessary. (cherry picked from commit cb34075)
michaelklishin
added a commit
that referenced
this pull request
Feb 27, 2023
Quorum queues: chunk consumer log effects (backport #7175)
|
It was decided to ship this only in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunk quorum queue deliveries
This puts a limit to the amount of message data that is added
to the process heap at the same time to around 128KB.
Large prefetch values combined with large messages could cause
excessive garbage collection work.
Also simplify the intermediate delivery message format to avoid
allocations that aren't necessary.