rabbit_db: Add init/0, is_virgin_node/0, dir/0 and ensure_dir_exists/0 functions
#6866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
init-db-from-rabbit_db
branch
2 times, most recently
from
db51669 to
60203bc
Compare
Here is an example:
?LOG_DEBUG(
"DB: initialization successeful",
#{domain => ?RMQLOG_DOMAIN_DB}),
…exists/0` functions These functions sit on top of their equivalent in `rabbit_mnesia`. In the future, they will take care of picking the right database layer, whatever it is. The start of `mnesia_sync` is now part of this initialization instead of a separate boot step in `rabbit` because it is specific to our use of Mnesia. In addition, `rabbit_db` provides `is_virgin_node/1` to query the state of a remote node. This is used by `rabbit_ff_controller` in the feature flags subsystem. At this point, the underlying equivalent functions in `rabbit_mnesia` become private to this module (and other modules implementing the interaction with Mnesia). Other parts of RabbitMQ, including plugins, should now use `rabbit_db`, not `rabbit_mnesia`.
…es sense Some testcases are interested in RabbitMQ data directory, not Mnesia directory per se. In this case, call `rabbit:data_dir/0` instead.
dumbbell
force-pushed
the
init-db-from-rabbit_db
branch
from
60203bc to
950c4ef
Compare
dumbbell
changed the title
rabbit_dbinit/0, is_virgin_node/0, dir/0 and ensure_dir_exists/0 functions
the-mikedavis
approved these changes
Jan 13, 2023
dcorbacho
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions sit on top of their equivalent in
rabbit_mnesia. In the future, they will take care of picking the right database layer, whatever it is.The start of
mnesia_syncis now part of this initialization instead of a separate boot step inrabbitbecause it is specific to our use of Mnesia.In addition,
rabbit_dbprovidesis_virgin_node/1to query the state of a remote node. This is used byrabbit_ff_controllerin the feature flags subsystem.At this point, the underlying equivalent functions in
rabbit_mnesiabecome private to this module (and other modules implementing the interaction with Mnesia). Other parts of RabbitMQ, including plugins, should now userabbit_db, notrabbit_mnesia.This is a follow-up to #6430. It is a preparation step to be able to change the database layer.