Auto deleted queue log #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 4, 2016 11:49
|
This needs some work, as explained on Slack. It currently uses not particularly clear wording and doesn't distinguish between exclusive and auto-delete queues, which have different removal reasons/events. |
| @@ -142,6 +142,8 @@ init_it(Recover, From, State = #q{q = #amqqueue{exclusive_owner = Owner}}) -> | |||
| {_, Terms} = recovery_status(Recover), | |||
| BQS = bq_init(BQ, Q, Terms), | |||
| %% Rely on terminate to delete the queue. | |||
| log_auto_delete("Exclusive query connection closed", | |||
There was a problem hiding this comment.
You probably mean "queue", not "query". Also, this conflates exclusive and auto-delete queues. That's confusing, please use separate functions with clearer wording (as discussed on Slack).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #590
Added some functionality to logging:
error_loggermessages. Works same way asrabbit_sinks.