Make credit flow state transition interval 1s instead of 5s #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| %% if current process was blocked by credit flow | ||
| %% in the last STATE_CHANGE_INTERVAL millisecond, | ||
| %% state/0 will report it as "in flow". | ||
| -define(STATE_CHANGE_INTERVAL, 100000). |
There was a problem hiding this comment.
I think you are missing a zero.
Management UI and HTTP API currently report connections and channels as in flow if they've been in flow for the last 5 seconds. That can confuse the user with inter-node flow control, making them believe the flow is permanent (it is not: the actual state toggles many times a second). This reduces the interval to 1s, which seems more reasonable and accurate (in a way). Fixes #138.
dumbbell
force-pushed
the
rabbitmq-server-138
branch
from
5fae66f to
7710829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Management UI and HTTP API currently report connections and channels
as in flow if they've been in flow for the last 5 seconds. That
can confuse the user with inter-node flow control, making them
believe the flow is permanent (it is not: the actual state
toggles many times a second).
This reduces the interval to 1s, which seems more reasonable and
accurate (in a way).
Fixes #138.