Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mc: introduce new function in mc_amqp to init mc from stream data #13307

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

kjnilsson
Copy link
Contributor

@kjnilsson kjnilsson commented Feb 13, 2025

Initialising a message container from data stored in a
stream is a special case where we need to recover exchange
and routing key information from the following message annatations:

  • x-exchange
  • x-routing-key
  • x-cc

We do not want to do this when initialising a message container
from AMQP data just received from a publisher.

This commit introduces a new function mc_amqp:init_from_stream/2
that is to be used when needing a message container from a stream
message.

@kjnilsson kjnilsson force-pushed the recover-exch-rk-from-amqp branch 2 times, most recently from 4d24008 to ae23291 Compare February 13, 2025 10:44
@kjnilsson kjnilsson changed the title Mc: restore recovery of routing_keys and echange annotations Mc: introduce new function in mc_amqp to init mc from stream data Feb 13, 2025
@kjnilsson kjnilsson requested review from ansd and dcorbacho February 13, 2025 10:45
@kjnilsson kjnilsson marked this pull request as ready for review February 13, 2025 10:45
@kjnilsson kjnilsson added this to the 4.0.7 milestone Feb 13, 2025
@kjnilsson kjnilsson force-pushed the recover-exch-rk-from-amqp branch from ae23291 to 7e72e2e Compare February 13, 2025 10:48
Initialising a message container from data stored in a
stream is a special case where we need to recover exchange
and routing key information from the following message annatations:

* x-exchange
* x-routing-keys
* x-cc

We do not want to do this when initialising a message container
from AMQP data just received from a publisher.

This commit introduces a new function `mc_amqp:init_from_stream/2`
that is to be used when needing a message container from a stream
message.
@kjnilsson kjnilsson force-pushed the recover-exch-rk-from-amqp branch from 7e72e2e to 32615bf Compare February 13, 2025 10:52
ansd added a commit to rabbitmq/rabbitmq-website that referenced this pull request Feb 13, 2025
ansd added a commit to rabbitmq/rabbitmq-website that referenced this pull request Feb 13, 2025
@michaelklishin michaelklishin merged commit a24aef6 into main Feb 13, 2025
269 of 270 checks passed
@michaelklishin michaelklishin deleted the recover-exch-rk-from-amqp branch February 13, 2025 18:14
michaelklishin added a commit that referenced this pull request Feb 13, 2025
Mc: introduce new function in mc_amqp to init mc from stream data (backport #13307)
@michaelklishin michaelklishin modified the milestones: 4.0.7, 4.1.0 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants