Simplified OCI builds #13160
Merged
Simplified OCI builds #13160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use the official erlang image as the base (no more openssl and erlang recompilation) * by default, build with OTP27 for x86 only but make it easy to request any other OTP version and an ARM64 image * better docker layer caching * simplify the workflow and the Dockerfile
michaelklishin
approved these changes
Jan 29, 2025
|
@Mergifyio backport v4.0.x |
✅ Backports have been created
|
michaelklishin
added a commit
that referenced
this pull request
Jan 31, 2025
michaelklishin
pushed a commit
that referenced
this pull request
Jan 31, 2025
michaelklishin
added a commit
that referenced
this pull request
Jan 31, 2025
Simplified OCI builds (backport #13160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR only affects the image we build for our testing purposes (
pivotalrabbitmq/rabbitmq) and not the one used by users (calledrabbtimqand maintained by Docker)TODO: currently the PR pushes images toDONEpivotalrabbitmq/rabbitmq-test. After the review, I'll change it to push topivotalrabbitmq/rabbitmq.Changes included in this PR:
erlangimage as the base, we get the regular updates for free (in the past we had to manually bump Erlang/OpenSSL)If we backport this PR to
v4.0.x, we should probably change the default OTP version to 26 in the backport