QQ: resend pending commands when new leader detected on applied notif… #13095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
qq-resend-pending-commands-on-applied
branch
from
4aba0d2 to
8c8df9e
Compare
kjnilsson
force-pushed
the
qq-resend-pending-commands-on-applied
branch
from
8c8df9e to
fd4f580
Compare
kjnilsson
force-pushed
the
qq-resend-pending-commands-on-applied
branch
2 times, most recently
from
9d7a35a to
e26b0e6
Compare
kjnilsson
force-pushed
the
qq-resend-pending-commands-on-applied
branch
from
e26b0e6 to
6d417bf
Compare
ansd
approved these changes
Jan 22, 2025
…ication. When a leader changes all enqueuer and consumer processes are notified from the `state_enter(leader,` callback. However a new leader may not yet have applied all commands that the old leader had. If any of those commands is a checkout or a register_enqueuer command these processes will not be notified of the new leader and thus may never resend their pending commands. The new leader will however send an applied notification when it does apply these entries and these are always sent from the leader process so can also be used to trigger pending resends. This commit implements that.
kjnilsson
force-pushed
the
qq-resend-pending-commands-on-applied
branch
from
6d417bf to
d31b9aa
Compare
michaelklishin
added a commit
that referenced
this pull request
Jan 22, 2025
QQ: resend pending commands when new leader detected on applied notif… (backport #13095)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ication.
When a leader changes all enqueuer and consumer processes are notified from the
state_enter(leader,callback. However a new leader may not yet have applied all commands that the old leader had. If any of those commands is a checkout or a register_enqueuer command these processes will not be notified of the new leader and thus may never resend their pending commands.The new leader will however send an applied notification when it does apply these entries and these are always sent from the leader process so can also be used to trigger pending resends. This commit implements that.
Most likely fixes the jepsen failure in https://github.com/rabbitmq/jepsen/actions/runs/12606905118 - however proving this could be extremely difficult.