Prevent node from booting if credit_flow_default_credit is not valid #13046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimmyWang6
force-pushed
the
add-credit-verify
branch
from
26f320b to
b6df874
Compare
JimmyWang6
force-pushed
the
add-credit-verify
branch
from
b6df874 to
8164875
Compare
JimmyWang6
changed the title
ansd
requested changes
Jan 10, 2025
deps/rabbit/src/rabbit.erl
Outdated
| @@ -300,6 +300,8 @@ | |||
| %% 100 ms | |||
| -define(BOOT_STATUS_CHECK_INTERVAL, 100). | |||
|
|
|||
| -define(DEFAULT_CREDIT, {400, 200}). | |||
There was a problem hiding this comment.
We already have this default defined in
rabbitmq-server/deps/rabbit/Makefile
Line 84 in 9af2be3
Defining yet another default in another place (rabbit.erl) for the case of user misconfiguration is hard to justify. As @michaelklishin suggested in the discussion, instead of emitting a warning, let's make the node boot fail by throw()ing an error.
JimmyWang6
force-pushed
the
add-credit-verify
branch
from
80a6bdb to
2394d42
Compare
michaelklishin
changed the title
michaelklishin
changed the title
michaelklishin
added a commit
that referenced
this pull request
Jan 12, 2025
|
Finished and merged in #13055. I will backport it manually to |
michaelklishin
added a commit
that referenced
this pull request
Jan 12, 2025
(cherry picked from commit 3dd3433)
michaelklishin
added a commit
that referenced
this pull request
Jan 12, 2025
Awesome. thanks for your help! |
|
This PR makes booting the node fail if |
|
@ansd correct, I have considered this and have left the original condition in place. Let's change that to "lesser or equal". |
michaelklishin
added a commit
that referenced
this pull request
Jan 12, 2025
michaelklishin
added a commit
that referenced
this pull request
Jan 12, 2025
…itialCredit (cherry picked from commit 208d3d6)
|
Done. |
mkuratczyk
added a commit
that referenced
this pull request
Jan 14, 2025
#13046 introduced additional checks which prevent setting `{credit_flow_default_credit,{0,0}}`. Setting credits to zero allows disabling the credit flow mechanism (we use it in our benchmarks and mention for example in https://www.rabbitmq.com/blog/2023/03/21/native-mqtt)
mkuratczyk
added a commit
that referenced
this pull request
Jan 14, 2025
#13046 introduced additional checks which prevent setting `{credit_flow_default_credit,{0,0}}`. Setting credits to zero allows disabling the credit flow mechanism (we use it in our benchmarks and mention for example in https://www.rabbitmq.com/blog/2023/03/21/native-mqtt)
mergify bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
#13046 introduced additional checks which prevent setting `{credit_flow_default_credit,{0,0}}`. Setting credits to zero allows disabling the credit flow mechanism (we use it in our benchmarks and mention for example in https://www.rabbitmq.com/blog/2023/03/21/native-mqtt) (cherry picked from commit a4634d3)
mkuratczyk
added a commit
that referenced
this pull request
Jan 14, 2025
#13046 introduced additional checks which prevent setting `{credit_flow_default_credit,{0,0}}`. Setting credits to zero allows disabling the credit flow mechanism (we use it in our benchmarks and mention for example in https://www.rabbitmq.com/blog/2023/03/21/native-mqtt) (cherry picked from commit a4634d3) Co-authored-by: Michal Kuratczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As mention in previous discussion thread, this PR add adds validation for
param
credit_flow_default_credit, and change it to default value for the following two cases:Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.