Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building CLI with elixir 1.18.x #12928

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

VlkrS
Copy link
Contributor

@VlkrS VlkrS commented Dec 12, 2024

Tested with elixir 1.18.0-rc0, trivial change that should work without signing a CLA

Proposed Changes

Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

A pull request that doesn't explain why the change was made has a much lower chance of being accepted.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

Tested with elixir 1.18.0-rc0
@pivotal-cla
Copy link

@VlkrS Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@michaelklishin
Copy link
Member

@pivotal-cla this is an obvious fix

@pivotal-cla
Copy link

@VlkrS This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@michaelklishin michaelklishin merged commit fdfbaf8 into rabbitmq:main Dec 12, 2024
263 of 267 checks passed
@michaelklishin
Copy link
Member

@VlkrS thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants