rabbit_feature_flags: Avoid deadlock on terminating controller #11414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch looks good to me and I tested it successfully locally. There are some (unrelated?) regressions in CI that we need to address before we can merge. |
dcorbacho
force-pushed
the
ff-controller-block-startup-v2
branch
from
0e6f479 to
0d2fd7a
Compare
michaelklishin
force-pushed
the
ff-controller-block-startup-v2
branch
from
0d2fd7a to
708be17
Compare
|
The forced push was a rebase. |
|
@dcorbacho: Could you please prefix your commit message with |
dcorbacho
force-pushed
the
ff-controller-block-startup-v2
branch
from
708be17 to
334883b
Compare
If the global process is itself, it means it just crashed. It shouldn't wait but terminate
dcorbacho
force-pushed
the
ff-controller-block-startup-v2
branch
from
334883b to
e898658
Compare
dumbbell
changed the title
michaelklishin
added a commit
that referenced
this pull request
Jun 13, 2024
rabbit_feature_flags: Avoid deadlock on terminating controller (backport #11414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the global process is itself, it means it just crashed. It shouldn't wait but terminate.
As discussed with @dumbbell
Probably supersedes #11392