Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Periodically reconcile virtual host processes (backport #11407) #11408

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Periodically reconcile virtual host processes (backport #11407) #11408

merged 9 commits into from
Jun 7, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 7, 2024

This is an updated version of #11363.

This is an automatic backport of pull request #11407 done by Mergify.

Michael Klishin and others added 8 commits June 7, 2024 03:30
@mergify
Periodically reconcile virtual host processes
a5d37f6 
for up to 10 times.

When a cluster is formed from scratch and a virtual
host is declared in the process (can be via
definitions, or plugins, or any other way),
that virtual host's process tree will be started
on all reachable cluster nodes at that moment
in time.

However, this can be just a subset of all nodes
expected to join the cluster.

The most effective solution is to run this
reconciliation process on a timer for up to
5 minutes by default. This matches how long
some other parts of RabbitMQ (3.x) expect
cluster formation to take, at most.

Per discussion with @dcorbacho @mkuratczyk.

(cherry picked from commit 37778fd)

# Conflicts:
#	deps/rabbit/src/rabbit.erl
@michaelklishin @mergify
Introduce 'rabbitmqctl reconcile_vhosts'
274d7d3 
(cherry picked from commit 6e41d3e)
@michaelklishin @mergify
Reconcile virtual hosts shortly after a cluster member is detected to…
3561ad2 
… have come online

(cherry picked from commit 5337f8f)
@michaelklishin @mergify
CLI: mix format
8e0279c 
(cherry picked from commit 27269b7)
@michaelklishin @mergify
Introduce a way to disable virtual host reconciliation
4b16160 
Certain test suites need virtual hosts to be down
for an extended period of time, and this feature
gets in a way ;)

(cherry picked from commit 1fc325f)
@michaelklishin @mergify
Simplify a rabbitmqctl_integration_SUITE test
7dcc520 
(cherry picked from commit 959d3fd)
@michaelklishin @mergify
Bump google-github-actions/auth here
adb096e 
(cherry picked from commit d109430)
@michaelklishin @mergify
Pass Dialyzer
41f3db7 
(cherry picked from commit c03d90f)
@mergify mergify bot added the conflicts label Jun 7, 2024
@mergify Mergify
Copy link
Author

mergify bot commented Jun 7, 2024

Cherry-pick of 37778fd has failed:

On branch mergify/bp/v3.13.x/pr-11407
Your branch is up to date with 'origin/v3.13.x'.

You are currently cherry-picking commit 37778fd934.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   deps/rabbit/BUILD.bazel
	modified:   deps/rabbit/Makefile
	modified:   deps/rabbit/app.bzl
	new file:   deps/rabbit/src/rabbit_vhosts.erl
	modified:   deps/rabbitmq_auth_backend_http/BUILD.bazel
	modified:   moduleindex.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   deps/rabbit/src/rabbit.erl

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@michaelklishin michaelklishin added this to the 3.13.4 milestone Jun 7, 2024
@michaelklishin michaelklishin merged commit e5a0520 into v3.13.x Jun 7, 2024
11 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v3.13.x/pr-11407 branch June 7, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelklishin michaelklishin

Labels
bazel conflicts make
Projects
None yet
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelklishin