Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a management UI issue with a page refresh after logging out #11226

Merged
merged 3 commits into from
May 14, 2024

Conversation

MarcialRosales
Copy link
Contributor

Fix issue #11224

Proposed Changes

Declare the missing function which redirects the user to the home page, i.e. to the login page.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Select not to refresh
so that it takes the user to the home page
It was not backported from v3.11
@michaelklishin michaelklishin changed the title Fix logout issue in management ui Fix a management UI issue with a page refresh after logging out May 14, 2024
@MarcialRosales MarcialRosales marked this pull request as ready for review May 14, 2024 11:17
@MarcialRosales MarcialRosales self-assigned this May 14, 2024
@michaelklishin
Copy link
Member

I could reproduce the (usability) issue and indeed, this PR address it.

@michaelklishin michaelklishin merged commit f93f901 into main May 14, 2024
18 checks passed
@michaelklishin michaelklishin deleted the fix-11224 branch May 14, 2024 12:55
michaelklishin added a commit that referenced this pull request May 14, 2024
Fix a management UI issue with a page refresh after logging out (backport #11226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants