Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbit_quorum_queue_periodic_membership_reconciliation:on_node_down s… #11134

Conversation

SimonUnge
Copy link
Member

(Unsure if I needed a PR for both 3.13.x and main branch, but made 2)

Noticed that rabbit_quorum_queue_periodic_membership_reconciliation:on_node_down/1 was only called for mnesia backend.

Proposed Changes
Call it regardless of mnesia/khepri

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@michaelklishin michaelklishin force-pushed the v3.13.x_membership_reconciliation_khepri branch from 5828f81 to d81d9c1 Compare May 4, 2024 02:09
@michaelklishin
Copy link
Member

The forced push was a rebase.

@michaelklishin michaelklishin added this to the 3.13.3 milestone May 4, 2024
@michaelklishin michaelklishin merged commit 3c5b08b into rabbitmq:v3.13.x May 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants