Respect message_interceptors.incoming.set_header_timestamp #10925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
approved these changes
Apr 8, 2024
ansd
force-pushed
the
mc-timestamp
branch
3 times, most recently
from
6e4cd63 to
ac6dc68
Compare
When feature flag message_containers is enabled, setting ``` message_interceptors.incoming.set_header_timestamp ``` wasn't respected anymore when a message is published via MQTT to a stream and subsequently consumed via AMQP 0.9.1. This commit ensures that AMQP 0.9.1 header timestamp_in_ms will be set. Note that we must not modify the AMQP 1.0 properties section when messages are received via AMQP 1.0 and consumed via AMQP 1.0. Also, message annoation keys not starting with "x-" are reserved.
kjnilsson
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect message_interceptors.incoming.set_header_timestamp
When feature flag message_containers is enabled, setting
wasn't respected anymore when a message is published via MQTT to a stream and subsequently consumed via AMQP 0.9.1.
This commit ensures that AMQP 0.9.1 header timestamp_in_ms will be set.
Note that we must not modify the AMQP 1.0 properties section when messages are received via AMQP 1.0 and consumed via AMQP 1.0.
Also, message annoation keys not starting with "x-" are reserved.
Reported in