rabbitmq_federation: Handle shutdown from upstream
#10471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why]
The downstream process was already handling a `{shutdown, Term}`
termination reason from upstream gracefully: it would log a message an
close the connection.
However it didn't handle the more common `shutdown` reason, which
happens with a regular stop of the upstream node. It led to the log of a
giant scary crash message.
[How]
We handle `shutdown` the same as `{shutdown, Term}`.
michaelklishin
approved these changes
Feb 2, 2024
michaelklishin
deleted the
handle-shutdown-reason-in-federation-downstream
branch
michaelklishin
added a commit
that referenced
this pull request
Feb 2, 2024
rabbitmq_federation: Handle `shutdown` from upstream (backport #10471)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The downstream process was already handling a
{shutdown, Term}termination reason from upstream gracefully: it would log a message an close the connection.However it didn't handle the more common
shutdownreason, which happens with a regular stop of the upstream node. It led to the log of a giant scary crash message.How
We handle
shutdownthe same as{shutdown, Term}.