Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue emits too many consumer_closed events on channel down #86

Closed
simonmacmullen opened this issue Mar 30, 2015 · 2 comments
Closed

Queue emits too many consumer_closed events on channel down #86

simonmacmullen opened this issue Mar 30, 2015 · 2 comments
Labels
bug effort-low
Milestone
3.5.1

Comments

@simonmacmullen
Copy link
Contributor

See https://groups.google.com/d/msg/rabbitmq-users/nvCFKJ0HWH0/pbuNVKM3beoJ

The queue is emitting a consumer_closed event for every consumer, not just those associated with the channel. This doesn't lead to incorrect behaviour because the management plugin doesn't find the "wrong" consumers to delete since they have the wrong channel pid, but we do more work than needed. O(n^2) in fact :-(
@simonmacmullen
Copy link
Contributor Author

Since bug 25938 so 3.3.0.

simonmacmullen pushed a commit that referenced this issue Mar 30, 2015
erase_ch/2 should return ctags for just the erased channel, not all o…
bd4f8ae 
…f them.

This was not noticed for a long time because the only use of those ctags
was to emit consumer_deleted events which were handled by the management
database, and it ignored invalid {channel, ctag} combinations.
However, it did end up doing more work - and closing n channels out
of m became O(nm) instead of just O(n). References #86.
@simonmacmullen simonmacmullen added this to the 3.5.1 milestone Mar 30, 2015
@simonmacmullen
Copy link
Contributor Author

Thanks to Dustin K for his work on this.

@simonmacmullen simonmacmullen mentioned this issue Apr 2, 2015
Closed
dcorbacho pushed a commit that referenced this issue May 27, 2016
@michaelklishin
Merge pull request #86 from rabbitmq/rabbitmq-trust-store-14
dc4ab46 
Support otp style verify_fun ssl option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug effort-low
Projects
None yet
Milestone
3.5.1
Development

No branches or pull requests
1 participant
@simonmacmullen